[SDK] Consolidate tests to avoid excessive deployERC1155Contract #5135

kien-ngo · 2024-10-23T05:22:05Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR primarily focuses on updating the test cases for the erc1155 extension in the thirdweb package. It removes obsolete tests, adds new functionality tests, and modifies existing tests to improve coverage and accuracy for minting and NFT retrieval functionalities.

Detailed summary

Deleted several test files related to erc1155 functions.
Updated lazyMint.test.ts to use DROP1155_CONTRACT.
Added tests for isGetNFTsSupported in drop1155.test.ts and token1155.test.ts.
Refactored mintAdditionalSupplyToBatch.test.ts for clarity and correctness.
Enhanced checks for updateTokenURI and multi-token minting in token1155.test.ts.
Included additional assertions for owned token IDs in token1155.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-10-23T05:22:08Z

⚠️ No Changeset found

Latest commit: 71aa257

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-10-23T05:22:08Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 23, 2024 6:40am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 23, 2024 6:40am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 23, 2024 6:40am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 23, 2024 6:40am

graphite-app · 2024-10-23T05:22:10Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

kien-ngo · 2024-10-23T05:22:23Z

[SDK] Consolidate tests to avoid excessive deployERC1155Contract #5135 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

github-actions · 2024-10-23T05:25:57Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.81 KB (0%)	857 ms (0%)	709 ms (+30.19% 🔺)	1.6 s
thirdweb (cjs)	102.66 KB (0%)	2.1 s (0%)	1.4 s (+3.7% 🔺)	3.4 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	60 ms (-31.88% 🔽)	157 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	9 ms (-21.15% 🔽)	19 ms
thirdweb/react (minimal + tree-shaking)	17.33 KB (0%)	347 ms (0%)	105 ms (+38.78% 🔺)	451 ms

codecov · 2024-10-23T05:27:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.45%. Comparing base (c32576f) to head (71aa257).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5135   +/-   ##
=======================================
  Coverage   45.45%   45.45%           
=======================================
  Files        1065     1065           
  Lines       55122    55122           
  Branches     3975     3973    -2     
=======================================
  Hits        25054    25054           
  Misses      29376    29376           
  Partials      692      692

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from c32576f
packages	`40.47% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

graphite-app · 2024-10-23T06:36:13Z

Merge activity

Oct 23, 2:36 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 23, 2:40 AM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR primarily focuses on refactoring and enhancing the test coverage for the `erc1155` extension of the `thirdweb` package. It removes outdated tests, introduces new tests, and updates existing ones to improve functionality verification. ### Detailed summary - Removed multiple test files related to `erc1155` functions. - Updated `lazyMint.test.ts` to use `DROP1155_CONTRACT`. - Added a test for `isGetNFTsSupported` in `drop1155.test.ts`. - Simplified and enhanced tests in `mintAdditionalSupplyToBatch.test.ts`. - Introduced new tests for `updateTokenURI`, minting, and `getOwnedTokenIds` in `token1155.test.ts`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

kien-ngo marked this pull request as ready for review October 23, 2024 05:22

kien-ngo requested review from gregfromstl, jnsdls and joaquim-verges as code owners October 23, 2024 05:22

github-actions bot added the packages label Oct 23, 2024

vercel bot deployed to Preview – wallet-ui October 23, 2024 05:24 View deployment

vercel bot deployed to Preview – thirdweb_playground October 23, 2024 05:24 View deployment

vercel bot deployed to Preview – thirdweb-www October 23, 2024 05:32 View deployment

vercel bot deployed to Preview – docs-v2 October 23, 2024 05:33 View deployment

joaquim-verges approved these changes Oct 23, 2024

View reviewed changes

kien-ngo force-pushed the kien/update-erc1155-tests branch from 2110f3c to 71aa257 Compare October 23, 2024 06:37

vercel bot deployed to Preview – wallet-ui October 23, 2024 06:38 View deployment

vercel bot deployed to Preview – thirdweb_playground October 23, 2024 06:38 View deployment

vercel bot deployed to Preview – docs-v2 October 23, 2024 06:39 View deployment

vercel bot deployed to Preview – thirdweb-www October 23, 2024 06:40 View deployment

graphite-app bot merged commit 71aa257 into main Oct 23, 2024
30 checks passed

graphite-app bot deleted the kien/update-erc1155-tests branch October 23, 2024 06:40

vercel bot deployed to Production – wallet-ui October 23, 2024 06:42 View deployment

vercel bot deployed to Production – thirdweb_playground October 23, 2024 06:42 View deployment

vercel bot deployed to Production – docs-v2 October 23, 2024 06:43 View deployment

vercel bot deployed to Production – thirdweb-www October 23, 2024 06:50 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Consolidate tests to avoid excessive deployERC1155Contract #5135

[SDK] Consolidate tests to avoid excessive deployERC1155Contract #5135

Uh oh!

kien-ngo commented Oct 23, 2024 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

vercel bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 23, 2024

Uh oh!

kien-ngo commented Oct 23, 2024

Uh oh!

github-actions bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[SDK] Consolidate tests to avoid excessive deployERC1155Contract #5135

[SDK] Consolidate tests to avoid excessive deployERC1155Contract #5135

Uh oh!

Conversation

kien-ngo commented Oct 23, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

kien-ngo commented Oct 23, 2024

Uh oh!

github-actions bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kien-ngo commented Oct 23, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Oct 23, 2024 •

edited

Loading

vercel bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

codecov bot commented Oct 23, 2024 •

edited

Loading

graphite-app bot commented Oct 23, 2024 •

edited

Loading